feat(Table): add right sticky column support #8714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-8714.surge.sh A11y report: https://patternfly-react-pr-8714-a11y.surge.sh |
mmenestr
approved these changes
Feb 22, 2023
thatblindgeye
previously requested changes
Feb 27, 2023
packages/react-table/src/components/TableComposable/examples/ComposableTable.md
Outdated
Show resolved
Hide resolved
mattnolting
approved these changes
Mar 3, 2023
|
Created a followup for the v5 branch to update the |
wise-king-sullyman
approved these changes
Mar 3, 2023
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
tlabaj
pushed a commit
to tlabaj/patternfly-react
that referenced
this pull request
Apr 3, 2023
* feat(Table): add right sticky column support * Updated prop and example verbiage --------- Co-authored-by: Eric Olkowski <thatblindgeye@gmail.com>
jenny-s51
pushed a commit
that referenced
this pull request
Apr 4, 2023
* react-table: import from dist/esm like we do in react-core (#8708) This by large avoids importing from the high level export file from @patternfly/react-core as that exports the whole patternfly react exported modules, which affects consumers if tree-shaking algorithm does not mark them as dead code. Noticed these problematic imports while trying to port out project to 'esbuild' which created a noticably big dist'ed CSS because of these. [1] [1] evanw/esbuild#2933 * fix merge issues * fix conflict * Charts - back port label IDs (#8743) * fix(charts) ensure ChartAxis labels, as well as tick labels, are assigned unique IDs. Closes #8731 * chore(charts) fixed typo in documentation * chore(charts) remove comma for linter * fix(DatePicker): fixed errors in demos (#8760) * fix(DatePicker): fixed errors in demos * Updated error message in demos * fix(TimePicker): called onChange when pressing Enter (#8765) * fix(TimePicker): called onChange when pressing Enter * Added unit test * Updated unit test to ensure time suffix is present in onChange * feat(Table): add right sticky column support (#8714) * feat(Table): add right sticky column support * Updated prop and example verbiage --------- Co-authored-by: Eric Olkowski <thatblindgeye@gmail.com> * chore(cherry pick):Cherry picked v4 updates * update md file merge issues * disbal problematic test --------- Co-authored-by: Titani <tlabaj@redaht.com> Co-authored-by: Dan Labrecque <dlabrecq@redhat.com> Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> Co-authored-by: Eric Olkowski <thatblindgeye@gmail.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8632
Currently setting the
rightproperty manually. Will be updated to set--pf-c-table__sticky-column--Rightafter patternfly/patternfly#5393 is merged and rebased in.