-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DropdownToggle): Listen for touch events on the document to close a Toggle on mobile #1152
Conversation
… a Toggle on mobile Fixes Dropdown behavior on iOS devices. Also fixes a broken test that was never running assertions due to setTimeout. fix patternfly#1131
PatternFly-React preview: https://1152-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 3881
💛 - Coveralls |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What:
Fixes #1131, correcting dropdown behavior on iOS devices.
Additional issues:
Also fixes a broken test that was never running assertions due to setTimeout.