Collaboration branch for updating to core 167 #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlabaj
changed the title
* fix(Table): Use direct imports instead of spread * Do not show selects for collapsed rows
- patternfly4-react-lerna-root@1.42.4 - @patternfly/react-docs@3.21.13 - @patternfly/react-table@0.4.13
In PF core heading types of AboutModal were updated. This PR updates PF react with those changes. Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
- patternfly4-react-lerna-root@1.42.5 - @patternfly/react-core@1.51.4 - @patternfly/react-docs@3.21.14 - @patternfly/react-integration@1.0.12 - @patternfly/react-table@0.4.14
dmiller9911
reviewed
Jan 31, 2019
| `; | ||
|
|
||
| exports[`className is added to the root element 1`] = `"pf-c-login__footer-link extra-class"`; | ||
| exports[`className is added to the root element 1`] = `undefined`; |
There was a problem hiding this comment.
looks like this snapshot is not needed anymore
| @@ -20,11 +18,11 @@ const defaultProps = { | |||
| }; | |||
|
|
|||
| const ModalBoxCloseButton = ({ className, onClose, ...props }) => ( | |||
| <div {...props} className={css(styles.modalBoxClose, className)}> | |||
| <Button variant="plain" onClick={onClose} aria-label="Close"> | |||
| <React.Fragment> | |||
| <header {...props} className={css(styles.modalBoxHeader, className)}> | ||
| <h1 className={css(styles.modalBoxHeaderTitle)}>{children}</h1> | ||
| </header> | ||
| <React.Fragment> |
| max-width: calc(100% - 1rem - 1rem); | ||
| min-height: calc(undefined + undefined + undefined + undefined + undefined + undefined + calc(1rem * 4 * 1.5)); | ||
| width: 100%; | ||
| max-width: calc(100% - undefined - undefined); |
There was a problem hiding this comment.
Should the actually be undefined? In the past when i saw these it meant that core was referencing a variable that didn't actually exist.
There was a problem hiding this comment.
yep - these 2 variables don't exist. i just added a pr for the core build that checks for undefined variables. These 2 were among the scripts findings.
Pull Request Test Coverage Report for Build 4241
💛 - Coveralls |
|
PatternFly-React preview: https://1283-pr-patternfly-react-patternfly.surge.sh |
ibolton336
approved these changes
Jan 31, 2019
dgutride
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress for updating react to the version 167 of core. This branch can be used to colaborate on work for this update.