-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added browser tests after deploy #1312
Conversation
PatternFly-React preview: https://1312-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 4581
💛 - Coveralls |
a3a9598
to
386fdb4
Compare
Wow - this is great, is there an open issue on github tracking this work so we can understand the impact (and how the PatternFly team can help with this effort)? We won't be able to accept this in without at least an issue created on this repo that relates to this. @quarckster |
@dgutride done |
.travis/trigger_browser_tests.sh
Outdated
-H "Content-Type: application/json" \ | ||
-H "Accept: application/json" \ | ||
-H "Travis-API-Version: 3" \ | ||
-H "Authorization: token $QUARCKSTER_TOKEN" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need us to set this token on travis? I see it has been set, but it needs to be set by somebody on the PF team so we can keep track of what is used. @karelhala @quarckster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please set up this token in Travis settings. I've already provided token to @karelhala.
4f5c07e
to
8799525
Compare
@quarckster - this needs to be updated from mastser and then we can take it in |
8799525
to
8e49bda
Compare
@redallen please review |
f5e2848
to
9223a51
Compare
What:
QE use library https://github.com/quarckster/widgetastic.patternfly4 to run UI tests in Selenium. In order to keep up the changes in this repo it would be nice to trigger a travis job with browser tests that are described here https://github.com/quarckster/widgetastic.patternfly4/tree/master/testing.
Solves #1315