Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added browser tests after deploy #1312

Merged
merged 4 commits into from
Feb 21, 2019
Merged

Conversation

quarckster
Copy link
Contributor

@quarckster quarckster commented Feb 4, 2019

What:
QE use library https://github.com/quarckster/widgetastic.patternfly4 to run UI tests in Selenium. In order to keep up the changes in this repo it would be nice to trigger a travis job with browser tests that are described here https://github.com/quarckster/widgetastic.patternfly4/tree/master/testing.

Solves #1315

@karelhala karelhala changed the title Added browser tests after deploy [WIP] Added browser tests after deploy Feb 4, 2019
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://1312-pr-patternfly-react-patternfly.surge.sh

@coveralls
Copy link

coveralls commented Feb 4, 2019

Pull Request Test Coverage Report for Build 4581

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 31 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.5%) to 80.342%

Files with Coverage Reduction New Missed Lines %
packages/patternfly-4/react-core/src/components/Dropdown/Separator.js 1 80.0%
packages/patternfly-4/react-core/src/components/Dropdown/DropdownItem.js 4 34.52%
packages/patternfly-4/react-core/src/helpers/util.ts 26 14.29%
Totals Coverage Status
Change from base Build 4568: 1.5%
Covered Lines: 3361
Relevant Lines: 3918

💛 - Coveralls

@quarckster quarckster changed the title [WIP] Added browser tests after deploy Added browser tests after deploy Feb 4, 2019
@dgutride
Copy link
Member

dgutride commented Feb 4, 2019

Wow - this is great, is there an open issue on github tracking this work so we can understand the impact (and how the PatternFly team can help with this effort)? We won't be able to accept this in without at least an issue created on this repo that relates to this. @quarckster

@quarckster
Copy link
Contributor Author

@dgutride done

dgutride
dgutride previously approved these changes Feb 4, 2019
-H "Content-Type: application/json" \
-H "Accept: application/json" \
-H "Travis-API-Version: 3" \
-H "Authorization: token $QUARCKSTER_TOKEN" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need us to set this token on travis? I see it has been set, but it needs to be set by somebody on the PF team so we can keep track of what is used. @karelhala @quarckster

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please set up this token in Travis settings. I've already provided token to @karelhala.

@dgutride
Copy link
Member

@quarckster - this needs to be updated from mastser and then we can take it in

@quarckster
Copy link
Contributor Author

@redallen please review

.travis.yml Outdated Show resolved Hide resolved
@quarckster
Copy link
Contributor Author

@dgutride I rebased the PR and aligned it with @redallen comments.

@redallen redallen merged commit 5594d7c into patternfly:master Feb 21, 2019
@quarckster quarckster deleted the browser_tests branch February 25, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants