feat(Icons): Add fa regular icons and update solid icons #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw we are still missing FA-brands-free icons. Which is another 414 icons. |
|
PatternFly-React preview: https://1385-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 4516
💛 - Coveralls |
jschuler
previously approved these changes
Feb 15, 2019
tlabaj
previously approved these changes
Feb 19, 2019
karelhala
force-pushed
the
add-regular-icons
branch
from
615a1a8
to
4d9aa6c
Compare
kmcfaul
previously approved these changes
Feb 20, 2019
karelhala
force-pushed
the
add-regular-icons
branch
from
4d9aa6c
to
0b0b408
Compare
karelhala
force-pushed
the
add-regular-icons
branch
from
0b0b408
to
7a75d1b
Compare
karelhala
force-pushed
the
add-regular-icons
branch
from
7a75d1b
to
69f76cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #1385 +/- ##
=======================================
Coverage 83.41% 83.41%
=======================================
Files 543 543
Lines 5619 5619
Branches 12 12
=======================================
Hits 4687 4687
Misses 930 930
Partials 2 2
Continue to review full report at Codecov.
|
jschuler
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Because new icons were added to solid icons we should pull them and expose them for others as well.
Also add new package with regular icons (outlined solid) with prefix
outlined${IconName}so we don't have any name clashes.Overall adds 277 of new icons!