Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(fixes): Fix TravisCI PF3 doc deploys #1400

Merged
merged 33 commits into from
Feb 18, 2019
Merged

build(fixes): Fix TravisCI PF3 doc deploys #1400

merged 33 commits into from
Feb 18, 2019

Conversation

redallen
Copy link
Contributor

@redallen redallen commented Feb 18, 2019

What: Fix deploying PF3 docs on publish. Also add root package version to allow yarn add https://github.com/patternfly/patternfly-react.git.

Additional issues:

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://1400-pr-patternfly-react-patternfly.surge.sh

@@ -20,7 +20,7 @@
},
"command": {
"publish": {
"message": "chore(release): releasing packages",
"message": "chore(release): releasing packages [ci skip]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

dgutride
dgutride previously approved these changes Feb 18, 2019
@coveralls
Copy link

coveralls commented Feb 18, 2019

Pull Request Test Coverage Report for Build 4639

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.2%) to 77.127%

Totals Coverage Status
Change from base Build 4625: -3.2%
Covered Lines: 1504
Relevant Lines: 1794

💛 - Coveralls

jschuler
jschuler previously approved these changes Feb 18, 2019
@jschuler jschuler merged commit e572db2 into master Feb 18, 2019
@redallen redallen deleted the fix/circleci branch February 18, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants