build(publish): fix and improve lerna publish #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-React preview: https://1422-pr-patternfly-react-patternfly.surge.sh |
humblej86
suggested changes
Feb 21, 2019
| git rev-parse HEAD # helpful for debugging any lerna EUNCOMMIT errors | ||
|
|
||
| # Tag this new commit with each package change. Don't push it yet. | ||
| npx lerna version --conventional-commits --no-commit-hooks --no-git-tag-version --no-push --yes |
There was a problem hiding this comment.
Suggested change
| npx lerna version --conventional-commits --no-commit-hooks --no-git-tag-version --no-push --yes | |
| npx lerna version --conventional-commits --no-commit-hooks --no-git-tag-version --no-push --yes |
priley86
reviewed
Feb 21, 2019
| # Undo that last commit locally | ||
| git reset --hard HEAD~1 | ||
| # Now only if it publishes should we also push this commit to Github and do a Github release. |
There was a problem hiding this comment.
pretty nifty... seems it should work 👍
dgutride
approved these changes
Feb 21, 2019
priley86
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Rewrite
release.shto (hopefully) more consistently do what we want.Additional issues: Only way to fully test it is to actually do a release! I'm on standby to fix it if it goes wrong.