Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(lerna): fix build credentials #1425

Merged
merged 2 commits into from
Feb 21, 2019
Merged

build(lerna): fix build credentials #1425

merged 2 commits into from
Feb 21, 2019

Conversation

redallen
Copy link
Contributor

What: currently, lerna can't git push.

Additional issues:

dgutride
dgutride previously approved these changes Feb 21, 2019
View reviewed changes
tlabaj
tlabaj reviewed Feb 21, 2019
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redallen redallen merged commit 153e4b1 into patternfly:master Feb 21, 2019
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://1425-pr-patternfly-react-patternfly.surge.sh

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4736

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.344%
Totals Coverage Status
Change from base Build 4734: 0.0%
Covered Lines: 4673
Relevant Lines: 5545
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlabaj tlabaj tlabaj left review comments

@jschuler jschuler jschuler approved these changes

@dgutride dgutride dgutride approved these changes

@priley86 priley86 Awaiting requested review from priley86

@dlabaj dlabaj Awaiting requested review from dlabaj

@seanforyou23 seanforyou23 Awaiting requested review from seanforyou23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@redallen @patternfly-build @coveralls @jschuler @dgutride @tlabaj