Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testing): updates remaining tests to enzyme #282

Merged

Conversation

AllenBW
Copy link
Contributor

@AllenBW AllenBW commented Mar 21, 2018

continuation of #258, removes react-test-utils dep and swaps tests that were using this dep over to enzyme

@coveralls
Copy link

coveralls commented Mar 21, 2018

Pull Request Test Coverage Report for Build 1034

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 71.663%

Totals Coverage Status
Change from base Build 1020: 0.09%
Covered Lines: 1256
Relevant Lines: 1585

💛 - Coveralls

priley86
priley86 previously approved these changes Mar 21, 2018
@priley86 priley86 dismissed their stale review March 22, 2018 01:05

oh woops WIP ;)

@AllenBW AllenBW force-pushed the chore/update-tests-to-use-enzyme branch from c6fb795 to 396c54c Compare March 22, 2018 14:03
@AllenBW AllenBW changed the title [WIP] chore(testing): updates remaining tests to enzyme chore(testing): updates remaining tests to enzyme Mar 22, 2018
@AllenBW
Copy link
Contributor Author

AllenBW commented Mar 22, 2018

Outta WIP!! @jeff-phillips-18 @priley86 if ya'll wanta give this a quick look, updates the remaining testsssssssss

@priley86
Copy link
Member

thank you @AllenBW - very nice to drop the additional dependency.🥇

@jeff-phillips-18 jeff-phillips-18 merged commit 6356892 into patternfly:master Mar 23, 2018
@jgiardino jgiardino removed the review label Mar 23, 2018
@AllenBW AllenBW deleted the chore/update-tests-to-use-enzyme branch March 23, 2018 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants