Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts: Responsive legend #3067

Merged
merged 2 commits into from Oct 10, 2019
Merged

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Oct 3, 2019

Added support for responsive legends.

Fixes #3005

chrome-capture (2)

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 3, 2019

PatternFly-React preview: https://patternfly-react-pr-3067.surge.sh

@dlabrecq dlabrecq force-pushed the dlabrecq:3005-responsive-legend branch from 7dd0975 to 61317c9 Oct 3, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 3, 2019

Codecov Report

Merging #3067 into master will increase coverage by 0.05%.
The diff coverage is 26.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3067      +/-   ##
==========================================
+ Coverage   69.02%   69.07%   +0.05%     
==========================================
  Files         858      857       -1     
  Lines       23413    23457      +44     
  Branches     1853     1860       +7     
==========================================
+ Hits        16160    16203      +43     
+ Misses       6333     6310      -23     
- Partials      920      944      +24
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (ø) ⬆️
#patternfly4 68.22% <26.47%> (+0.12%) ⬆️
Impacted Files Coverage Δ
...ents/ChartDonutUtilization/ChartDonutThreshold.tsx 74.64% <ø> (+0.96%) ⬆️
...4/react-charts/src/components/ChartLegend/index.ts 100% <ø> (ø) ⬆️
...ct-charts/src/components/ChartDonut/ChartDonut.tsx 65.21% <100%> (+0.51%) ⬆️
...ct-charts/src/components/ChartPoint/ChartPoint.tsx 17.85% <12.5%> (+1.19%) ⬆️
...t-charts/src/components/ChartUtils/chart-legend.ts 32.32% <26.08%> (+21.71%) ⬆️
...ts/ChartDonutUtilization/ChartDonutUtilization.tsx 72.28% <50%> (-0.89%) ⬇️
...-charts/src/components/ChartLegend/ChartLegend.tsx 83.87% <50%> (-5.02%) ⬇️
...t-charts/src/components/ChartPoint/path-helpers.ts 3.84% <6.89%> (+1.92%) ⬆️
...nfly-4/react-charts/src/components/Chart/Chart.tsx 54.16% <60%> (-1.16%) ⬇️
.../react-charts/src/components/ChartPie/ChartPie.tsx 74.54% <60%> (-1.39%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 650c823...10219ca. Read the comment docs.

@dlabrecq dlabrecq force-pushed the dlabrecq:3005-responsive-legend branch 2 times, most recently from 61ae605 to c0535ad Oct 4, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:3005-responsive-legend branch from c0535ad to ef10cab Oct 5, 2019
Fixes #3005
@dlabrecq dlabrecq force-pushed the dlabrecq:3005-responsive-legend branch from ef10cab to 10219ca Oct 6, 2019
@mturley mturley merged commit 37a4a3b into patternfly:master Oct 10, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 10, 2019

Your changes have been released in:

  • @patternfly/react-charts@5.0.22

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.