Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linting): turning on errors for Markdown code block linting. We a… #3515

Merged
merged 1 commit into from Jan 15, 2020
Merged

fix(linting): turning on errors for Markdown code block linting. We a… #3515

merged 1 commit into from Jan 15, 2020

Conversation

ddonahue007
Copy link
Member

…re now ahead of the game.

By upping our rules from warning to error will cause build failures if any of the rules fail for code blocks inside Markdown files. This is important as it will keep our Demos and examples in a usable state.

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-3515.surge.sh

Copy link
Collaborator

@jschuler jschuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job 👍

@jschuler jschuler merged commit 55a8523 into patternfly:master Jan 15, 2020
@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #3515 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3515   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files         903      903           
  Lines       25482    25482           
  Branches     2257     2257           
=======================================
  Hits        17097    17097           
  Misses       7343     7343           
  Partials     1042     1042
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.19% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9452de...220dda7. Read the comment docs.

Copy link
Member

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddonahue007 ddonahue007 deleted the turn-on-md-lint-errors branch January 16, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants