Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility updates to alert for toast alerts #3519

Merged
merged 4 commits into from Jan 22, 2020
Merged

Accessibility updates to alert for toast alerts #3519

merged 4 commits into from Jan 22, 2020

Conversation

jessiehuff
Copy link
Contributor

@jessiehuff jessiehuff commented Jan 16, 2020 •
edited

What: Closes #1421

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-3519.surge.sh

@jessiehuff jessiehuff mentioned this pull request Jan 20, 2020
Merged
@codecov-io
Copy link

codecov-io commented Jan 20, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@0fb0a43). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3519   +/-   ##
=========================================
  Coverage          ?   67.09%           
=========================================
  Files             ?      903           
  Lines             ?    25486           
  Branches          ?     2260           
=========================================
  Hits              ?    17100           
  Misses            ?     7344           
  Partials          ?     1042
Flag Coverage Δ
#misc 100% <ø> (?)
#patternfly3 69.29% <ø> (?)
#patternfly4 64.31% <100%> (?)
Impacted Files Coverage Δ
...ernfly-4/react-core/src/components/Alert/Alert.tsx 82.05% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb0a43...d8ba6a7. Read the comment docs.

dlabrecq
dlabrecq approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

redallen
redallen approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@redallen redallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jessiehuff ! 🎖

@redallen redallen merged commit dc57757 into patternfly:master Jan 22, 2020
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.83
  • @patternfly/react-core@3.132.0
  • @patternfly/react-docs@4.16.101
  • @patternfly/react-inline-edit-extension@2.14.43
  • demo-app-ts@3.17.17
  • @patternfly/react-table@2.24.86
  • @patternfly/react-topology@2.11.70
  • @patternfly/react-virtualized-extension@1.3.84

Thanks for your contribution! 🎉

tlabaj
tlabaj reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing integration test and you need to add the new prop to the demo.

packages/patternfly-4/react-core/src/components/Alert/Alert.tsx
@@ -57,6 +60,7 @@ const Alert: React.FunctionComponent<AlertProps & InjectedOuiaProps> = ({
const customClassName = css(
styles.alert,
isInline && styles.modifiers.inline,
isToast && 'pf-m-live',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using the class name here instead of react-styles?

@jessiehuff jessiehuff mentioned this pull request Jul 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlabaj tlabaj tlabaj left review comments

@dlabrecq dlabrecq dlabrecq approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@redallen redallen redallen approved these changes

@seanforyou23 seanforyou23 Awaiting requested review from seanforyou23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alert: create variation to use for dynamic notifications
7 participants
@jessiehuff @patternfly-build @codecov-io @dlabrecq @tlabaj @kmcfaul @redallen