Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): Make IAction onClick optional #3558

Merged
merged 1 commit into from Jan 23, 2020

Conversation

Venefilyn
Copy link
Contributor

What: Closes #3557

Additional issues:

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-3558.surge.sh

@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #3558 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3558   +/-   ##
=======================================
  Coverage   67.11%   67.11%           
=======================================
  Files         903      903           
  Lines       25502    25502           
  Branches     2262     2262           
=======================================
  Hits        17115    17115           
  Misses       7346     7346           
  Partials     1041     1041
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.21% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...rnfly-4/react-table/src/components/Table/Table.tsx 91.25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 327402f...f7ae114. Read the comment docs.

Copy link
Collaborator

@seanforyou23 seanforyou23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this fixes that console error we've had for a while Warning: Failed prop type: Invalid prop actions[1] supplied to Table. - nice work!!

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit e4671f8 into patternfly:master Jan 23, 2020
@Venefilyn Venefilyn deleted the patch-1 branch January 23, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table IAction require onClick to be supplied
6 participants