feat(radio/check): add support for optional description #3621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-React preview: https://patternfly-react-pr-3621.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #3621 +/- ##
==========================================
+ Coverage 67.15% 67.17% +0.01%
==========================================
Files 907 907
Lines 25559 25563 +4
Branches 2267 2269 +2
==========================================
+ Hits 17165 17171 +6
+ Misses 7353 7352 -1
+ Partials 1041 1040 -1
Continue to review full report at Codecov.
|
dlabrecq
previously approved these changes
Jan 30, 2020
tlabaj
requested changes
Jan 30, 2020
mcoker
reviewed
Jan 30, 2020
packages/patternfly-4/react-core/src/components/Checkbox/Checkbox.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #3611