Hides Popover when its trigger is scrolled out of view #5318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PF4 preview: https://patternfly-react-pr-5318.surge.sh |
mcarrano
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #5317
Also adds a new prop to FocusTrap
preventScrollOnDeactivatewhich, when set to true prevents from scrolling back on deactivation. A related issue: #5240Also prevents FocusTrap from attempting to scroll back to the Popover trigger when deactivated
Demo
https://youtu.be/o7aV_68zc2U
Example code
https://pastebin.com/kuVNKy4g