Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(togglegroup): remove dividers, light variation, add compact #5762

Merged
merged 7 commits into from May 11, 2021
Merged

fix(togglegroup): remove dividers, light variation, add compact #5762

merged 7 commits into from May 11, 2021

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented May 10, 2021

What: Closes #5761

Additional issues: From core issue https://github.com/patternfly/patternfly/pull/4054/files

tlabaj
tlabaj requested changes May 10, 2021
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It just needs a couple of updates. he demo app needs to be updated to add the new prop. The variant prop also needs to be removed from the demo-app. An integration test for the new prop should be added.

@mcoker
Copy link
Contributor Author

mcoker commented May 10, 2021

@tlabaj updated!

redallen
redallen previously approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@redallen redallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcoker knows React? 🎉 🥇

@kmcfaul
Copy link
Contributor

kmcfaul commented May 10, 2021

LGTM code wise just need the build

@patternfly-build
Copy link
Contributor

patternfly-build commented May 10, 2021 •
edited

PF4 preview: https://patternfly-react-pr-5762.surge.sh
A11y report: https://patternfly-react-pr-5762-a11y.surge.sh

@mcoker mcoker requested a review from mcarrano May 11, 2021 14:56
mcarrano
mcarrano approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great from a UX perspective. Thanks @mcoker !

redallen
redallen approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@redallen redallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Godlike To Me.

tlabaj
tlabaj approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@tlabaj tlabaj merged commit d5c8c31 into patternfly:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcarrano mcarrano mcarrano approved these changes

@tlabaj tlabaj tlabaj approved these changes

@redallen redallen redallen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toggle group - remove use of divider between actions, remove light variation, add compact variation
6 participants
@mcoker @kmcfaul @patternfly-build @mcarrano @tlabaj @redallen