Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DataList): better comments for isChecked and checked props #6803

Merged
merged 1 commit into from Jan 20, 2022
Merged

fix(DataList): better comments for isChecked and checked props #6803

merged 1 commit into from Jan 20, 2022

Conversation

boaz0
Copy link
Member

@boaz0 boaz0 commented Jan 17, 2022

What: Closes #6762

@boaz0
fix(DataList): better comments for isChecked and checked props
83762d1 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@patternfly-build
Copy link
Contributor

Preview: https://patternfly-react-pr-6803.surge.sh

@tlabaj tlabaj merged commit a93c92e into patternfly:main Jan 20, 2022
@boaz0 boaz0 deleted the closes_6762 branch January 23, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolethoen nicolethoen nicolethoen approved these changes

@tlabaj tlabaj tlabaj approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@jpuzz0 jpuzz0 jpuzz0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataListCheck: decide on one of checked/isChecked and make sure the checked property is propagated on the DOM
6 participants
@boaz0 @patternfly-build @nicolethoen @tlabaj @kmcfaul @jpuzz0