Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ApplicationLauncher): Convert examples to typescript #6834

Merged
merged 3 commits into from
Jan 21, 2022
Merged

chore(ApplicationLauncher): Convert examples to typescript #6834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8a4605
chore(ApplicationLauncher): Convert examples to typescript
Jan 19, 2022
6881358
remove unnecessary memoizations/types
Jan 20, 2022
aeff92a
more renaming
Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-core/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
declare module '*.svg' {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason for this is mentioned here: #6791 (comment)

const content: string;
export default content;
}
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Alert/examples/AlertAsyncLiveRegion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ interface AlertInfo {

export const AsyncLiveRegionAlert: React.FunctionComponent = () => {
const [alerts, setAlerts] = React.useState<AlertInfo[]>([]);
const [isActive, setIsActive] = React.useState<boolean>(false);
const [isActive, setIsActive] = React.useState(false);
const getUniqueId: () => number = () => new Date().getTime();

const addAlert = (alertInfo: AlertInfo) => {
Expand Down