fix(TimePicker): apply includeSeconds when making options #6865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see in the description that this is fixing "errors", is the only error not that In any case, this looks to have fixed the reported issue linked. |
jpuzz0
approved these changes
Jan 28, 2022
|
@jeffpuzzo Calling it an error may not be accurate but I don't know which word is better to be used here. That's the incorrect comparison that could cause the option to be misjudged and not show the option because it's not comparing |
kmcfaul
approved these changes
Feb 7, 2022
nicolethoen
approved these changes
Feb 7, 2022
tlabaj
approved these changes
Feb 7, 2022
tlabaj
approved these changes
Feb 7, 2022
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #6837
When making time options for the dropdown menu, the
includeSecondsprops in not set. Which makes some errors when comparing option 00:00 with the min time 00:00:00 because they are not the same format.Also, update the doc to prevent some building warnings.