fix(NumberInput): Custom increment/decrement and thresholds #7159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-7159.surge.sh A11y report: https://patternfly-react-pr-7159-a11y.surge.sh |
There was a problem hiding this comment.
This is looking good! I am noticing some flooring occurring in the following situations however:
- when changing the input via keyboard, pressing Tab to go to the increment button, and pressing Tab again, the input floors to the min (or max if at the max).
- when pressing the buttons to increment/decrement and then clicking outside of the component, the same behavior as above occurs.
It looks like the onBlur is being applied to the input and the buttons, so whenever the buttons lose focus it's causing that newValue to become 0 before running through the ternary when setting the state.
jenny-s51
commented
Apr 1, 2022
There was a problem hiding this comment.
Awesome catch @thatblindgeye ! I've updated the component to apply onBlur only to the text input.
thatblindgeye
approved these changes
Apr 1, 2022
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #7069