Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(table): add fullscreen demo for error state #7443

Merged
merged 3 commits into from May 31, 2022
Merged

feat(table): add fullscreen demo for error state #7443

merged 3 commits into from May 31, 2022

Conversation

jenny-s51
Copy link
Contributor

What: Closes #7439

@patternfly-build
Copy link
Contributor

patternfly-build commented May 18, 2022 •
edited

Preview: https://patternfly-react-pr-7443.surge.sh

A11y report: https://patternfly-react-pr-7443-a11y.surge.sh

thatblindgeye
thatblindgeye approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good when compared to the Empty state demo PR! Awesome job getting these demos updated 💪🏼

@mattnolting mattnolting self-requested a review May 27, 2022 18:26
mattnolting
mattnolting approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great! Good work.

@tlabaj tlabaj merged commit eeab219 into patternfly:main May 31, 2022
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • eslint-plugin-patternfly-react@4.59.0
  • @patternfly/react-catalog-view-extension@4.71.0
  • @patternfly/react-charts@6.73.0
  • @patternfly/react-code-editor@4.61.0
  • @patternfly/react-console@4.71.0
  • @patternfly/react-core@4.220.0
  • @patternfly/react-docs@5.81.0
  • @patternfly/react-icons@4.71.0
  • @patternfly/react-inline-edit-extension@4.65.0
  • demo-app-ts@4.180.0
  • @patternfly/react-integration@4.182.0
  • @patternfly/react-log-viewer@4.65.0
  • @patternfly/react-styles@4.70.0
  • @patternfly/react-table@4.89.0
  • @patternfly/react-tokens@4.72.0
  • @patternfly/react-topology@4.67.0
  • @patternfly/react-virtualized-extension@4.67.0
  • transformer-cjs-imports@4.58.0

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattnolting mattnolting mattnolting approved these changes

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@tlabaj tlabaj tlabaj approved these changes

@mmenestr mmenestr mmenestr approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@mcarrano mcarrano Awaiting requested review from mcarrano

@mcoker mcoker Awaiting requested review from mcoker

Assignees
No one assigned
Labels
css review ux approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(table): Full screen demo for error state
7 participants
@jenny-s51 @patternfly-build @mattnolting @wise-king-sullyman @tlabaj @mmenestr @thatblindgeye