Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Accordion): update tests to new standards #7645

Merged

Conversation

wise-king-sullyman
Copy link
Contributor

What: Closes #7605

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 30, 2022

Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
And you may not love the nodeName property, but I imagine we'll be using it often whenever we have a configurable element - like heading levels and things like that.

@nicolethoen nicolethoen merged commit 24aa859 into patternfly:main Jul 11, 2022
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • eslint-plugin-patternfly-react@4.63.13
  • @patternfly/react-catalog-view-extension@4.75.13
  • @patternfly/react-charts@6.77.13
  • @patternfly/react-code-editor@4.65.13
  • @patternfly/react-console@4.75.13
  • @patternfly/react-core@4.224.13
  • @patternfly/react-docs@5.85.13
  • @patternfly/react-icons@4.75.13
  • @patternfly/react-inline-edit-extension@4.69.13
  • demo-app-ts@4.184.13
  • @patternfly/react-integration@4.186.13
  • @patternfly/react-log-viewer@4.69.13
  • @patternfly/react-styles@4.74.13
  • @patternfly/react-table@4.93.13
  • @patternfly/react-tokens@4.76.13
  • @patternfly/react-topology@4.71.13
  • @patternfly/react-virtualized-extension@4.71.13
  • transformer-cjs-imports@4.62.13

Thanks for your contribution! 🎉

@wise-king-sullyman wise-king-sullyman deleted the accordion-testing-update branch July 11, 2022 15:34
jenny-s51 pushed a commit to jenny-s51/patternfly-react that referenced this pull request Jul 26, 2022
* chore(Accordion): update tests to new standards

* fix demo app errors from incomplete integration test removal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion test revamp
4 participants