Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(table): update compact table data #7857

Merged
merged 1 commit into from Sep 7, 2022
Merged

chore(table): update compact table data #7857

merged 1 commit into from Sep 7, 2022

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Aug 17, 2022 •
edited

What: Closes #7855

Additional issues: Towards #7384

Convenience link to demo: https://patternfly-react-pr-7857.surge.sh/components/table/react-demos/compact/

@jenny-s51 jenny-s51 changed the title Compact table data chore(table): update compact table data Aug 17, 2022
@jenny-s51 jenny-s51 force-pushed the compactTableData branch 2 times, most recently from 00173ec to 108e5c9 Compare August 17, 2022 20:49
@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 17, 2022 •
edited

Preview: https://patternfly-react-pr-7857.surge.sh

A11y report: https://patternfly-react-pr-7857-a11y.surge.sh

nicolethoen
nicolethoen requested changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the URL cell is so long, i wonder if that should have a fixed width so the urls get truncated rather than the shorter Applications and Workspace titles.

packages/react-table/src/docs/demos/table-demos/Compact.jsx Outdated Show resolved Hide resolved
packages/react-table/src/docs/demos/table-demos/Compact.jsx Outdated Show resolved Hide resolved
packages/react-table/src/docs/examples/Data.jsx Outdated Show resolved Hide resolved
packages/react-table/src/docs/examples/Data.jsx Outdated Show resolved Hide resolved
packages/react-table/src/docs/examples/Data.jsx Outdated Show resolved Hide resolved
packages/react-table/src/docs/demos/table-demos/Compact.jsx Show resolved Hide resolved
@jenny-s51 jenny-s51 force-pushed the compactTableData branch 2 times, most recently from 8bf79da to bf24c62 Compare August 22, 2022 17:44
@jenny-s51 jenny-s51 changed the title chore(table): update compact table data [WIP] chore(table): update compact table data Aug 22, 2022
@jenny-s51 jenny-s51 marked this pull request as draft August 22, 2022 18:29
@jenny-s51 jenny-s51 mentioned this pull request Aug 23, 2022
Merged
@jenny-s51 jenny-s51 marked this pull request as ready for review August 23, 2022 20:31
@jenny-s51 jenny-s51 changed the title [WIP] chore(table): update compact table data chore(table): update compact table data Aug 23, 2022
nicolethoen
nicolethoen approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased

mcarrano
mcarrano approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks @jenny-s51 !

@tlabaj tlabaj merged commit eaeb4c2 into patternfly:main Sep 7, 2022
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • eslint-plugin-patternfly-react@4.75.12
  • @patternfly/react-catalog-view-extension@4.87.12
  • @patternfly/react-charts@6.89.12
  • @patternfly/react-code-editor@4.77.12
  • @patternfly/react-console@4.87.12
  • @patternfly/react-core@4.236.12
  • @patternfly/react-docs@5.97.12
  • @patternfly/react-icons@4.87.12
  • @patternfly/react-inline-edit-extension@4.81.12
  • demo-app-ts@4.196.12
  • @patternfly/react-integration@4.198.12
  • @patternfly/react-log-viewer@4.81.12
  • @patternfly/react-styles@4.86.12
  • @patternfly/react-table@4.105.12
  • @patternfly/react-tokens@4.88.12
  • @patternfly/react-topology@4.83.12
  • @patternfly/react-virtualized-extension@4.83.12
  • transformer-cjs-imports@4.74.12

Thanks for your contribution! 🎉

andyyvo pushed a commit to andyyvo/patternfly-react that referenced this pull request Sep 9, 2022
@jenny-s51 @andyyvo
add compact table data (patternfly#7857)
dbf6d11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcarrano mcarrano mcarrano approved these changes

@nicolethoen nicolethoen nicolethoen approved these changes

@tlabaj tlabaj tlabaj approved these changes

@mmenestr mmenestr Awaiting requested review from mmenestr

Assignees
No one assigned
Labels
ux review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table: Update compact demo data
5 participants
@jenny-s51 @patternfly-build @mcarrano @nicolethoen @tlabaj