Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tabs): change border bottom API #8517

Merged
merged 5 commits into from Jan 12, 2023
Merged

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Jan 9, 2023

What: Closes #8104

Core link where these v5 changes exist: https://patternfly-pr-5171.surge.sh/components/tabs/

@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 9, 2023

@jenny-s51 jenny-s51 linked an issue Jan 10, 2023 that may be closed by this pull request
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!
Can you either open a codemods issue, or (ideally) quickly write up a code mod to correspond to this issue?

Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nicolethoen nicolethoen merged commit 42b6988 into patternfly:v5 Jan 12, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.0.0-alpha.3
  • @patternfly/react-core@5.0.0-alpha.3
  • @patternfly/react-docs@6.0.0-alpha.3
  • @patternfly/react-table@5.0.0-alpha.3

Thanks for your contribution! 🎉

jenny-s51 added a commit to jenny-s51/patternfly-react that referenced this pull request Jan 27, 2023
* feat(applauncher): replace input with search input

* rebase

* wip tabs border styling update

* fix jest tests

* Delete TabsAndTablesAutoWidthTabs.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs - change border bottom API
6 participants