Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Card): set default component to "div" to match core #8601

Merged
merged 2 commits into from Feb 8, 2023
Merged

fix(Card): set default component to "div" to match core #8601

merged 2 commits into from Feb 8, 2023

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Jan 25, 2023 •
edited

What: Closes #8336

Codemod WIP: patternfly/pf-codemods#226

@jenny-s51 jenny-s51 force-pushed the iss8336 branch 2 times, most recently from ef6ddc0 to a2dff03 Compare January 25, 2023 20:24
@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 25, 2023 •
edited

Preview: https://patternfly-react-pr-8601.surge.sh

A11y report: https://patternfly-react-pr-8601-a11y.surge.sh

@jenny-s51 jenny-s51 force-pushed the iss8336 branch 2 times, most recently from 4de1d2f to 94ad6bf Compare January 27, 2023 19:00
thatblindgeye
thatblindgeye requested changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. Just a couple of things:

  • The description for the component prop needs to be updated
  • Can you open a followup in Org to update the a11y docs? That currently references article as the default.

@jenny-s51 jenny-s51 mentioned this pull request Jan 27, 2023
Closed
@jenny-s51 jenny-s51 requested a review from mcoker January 30, 2023 20:27
mcoker
mcoker approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L🚀TM!

@jenny-s51 jenny-s51 linked an issue Feb 2, 2023 that may be closed by this pull request
Bug - Card - set default component to "div" to match core #8336
Closed
tlabaj
tlabaj approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tlabaj tlabaj merged commit 5bdb551 into patternfly:v5 Feb 8, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-charts@7.0.0-alpha.4
  • @patternfly/react-code-editor@5.0.0-alpha.8
  • @patternfly/react-core@5.0.0-alpha.8
  • @patternfly/react-docs@6.0.0-alpha.9
  • @patternfly/react-table@5.0.0-alpha.8

Thanks for your contribution! 🎉

@nicolethoen nicolethoen mentioned this pull request Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcoker mcoker mcoker approved these changes

@tlabaj tlabaj tlabaj approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees
No one assigned
Labels
css approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - Card - set default component to "div" to match core
5 participants
@jenny-s51 @patternfly-build @mcoker @tlabaj @thatblindgeye