chore(NotificationBadge): remove deprecated isread prop

[gitdallas]

What: Closes #8090

[patternfly-build]

Preview: https://patternfly-react-pr-8626.surge.sh

A11y report: https://patternfly-react-pr-8626-a11y.surge.sh

[tlabaj]

I believe this should default to unread.
@mcoker, what are the implications of not setting a variant. It looks like no variant is styled as read.

@mmenestr should the default of the notification badge be unread?

[mmenestr]

@tlabaj hmmm the default in what sense?

[tlabaj]

@mmenestr In terms of the variant read, unread or attention
https://www.patternfly.org/v4/components/notification-badge#basic

[mcoker]

@tlabaj @mmenestr default and read do look the same. The core docs do say to specify a modifier for the state, though the requirement to add a state may have been a requirement from the previous designs, and looking at the code, it looks like the read modifier and default (no modifier) are the same more by chance, not because it's coded that way on purpose. A read notification badge is basically just an icon.

Unless we want to potentially introduce a "default" (no modifier) state for the notification badge that's different from "read", I think either updating the styling to be read by default (we would remove .pf-m-read) or assigning a default value for variant (variant={NotificationBadgeVariant.read}) (like the variant prop, since a button also requires a modifier) would be fine.

A default/no-modifier badge could be something like

• neither read or unread, maybe you haven't clicked on it, or there is no state change regardless what you do to it
• we want a default state to be the regular icon button color (color-200) and the "read" color to be more grey, and/or italic (if there is text) or something

[mcoker]

lgtm other than the question about the default. Currently no variant (or an invalid one) renders the component without a modifier and the core docs mention the component needs a specified state, so if we keep that requirement, I think we would add "read" as the default for variant

[tlabaj]

LGTM

[mcoker]

👍👍

[patternfly-build]

Your changes have been released in:

• @patternfly/react-charts@7.0.0-alpha.5
• @patternfly/react-code-editor@5.0.0-alpha.9
• @patternfly/react-core@5.0.0-alpha.9
• @patternfly/react-docs@6.0.0-alpha.10
• @patternfly/react-table@5.0.0-alpha.9

Thanks for your contribution! 🎉