feat(Checkbox): changed order of onChange params #8750
Conversation
|
Preview: https://patternfly-react-pr-8750.surge.sh A11y report: https://patternfly-react-pr-8750-a11y.surge.sh |
|
Just realized that I didn't need to have the explicit types everywhere like I did. I'll be pushing a change shortly to remove those where not needed to tidy things up. |
| @@ -117,7 +117,7 @@ class SingleSelectInput extends React.Component { | |||
| <Checkbox | |||
| label="isDisabled" | |||
| isChecked={this.state.isDisabled} | |||
| onChange={this.toggleDisabled} | |||
| onChange={(_event, checked) => this.toggleDisabled(checked)} | |||
There was a problem hiding this comment.
on some of these files where there are a ton of onChange, i think i would have updated the toggleDisabled to have the event param. the diff would then have 1 change vs a bunch, and the unused prop in 1 place vs many.
although i'm not sure if there is a standard for whether the unused param should be here or there
There was a problem hiding this comment.
I think each toggleDisabled here was in a different example, so changing it at the function declaration level wouldn't have reduced the number of changes needed. Could be mistaken though.
What: Closes #8697
Additional issues: