Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DropdownToggleCheckbox): updated onChange param order #8787

Merged
merged 1 commit into from Mar 22, 2023
Merged

fix(DropdownToggleCheckbox): updated onChange param order #8787

merged 1 commit into from Mar 22, 2023

Conversation

Dominik-Petrik
Copy link
Contributor

What: Closes #8784

@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 7, 2023 •
edited

Preview: https://patternfly-react-pr-8787.surge.sh

A11y report: https://patternfly-react-pr-8787-a11y.surge.sh

tlabaj
tlabaj reviewed Mar 10, 2023
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolethoen nicolethoen merged commit dd07e4b into patternfly:v5 Mar 22, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.0.0-alpha.43
  • @patternfly/react-core@5.0.0-alpha.43
  • @patternfly/react-docs@6.0.0-alpha.46
  • demo-app-ts@5.0.0-alpha.27
  • @patternfly/react-table@5.0.0-alpha.43

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolethoen nicolethoen nicolethoen approved these changes

@tlabaj tlabaj tlabaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DropdownToggleCheckbox: change param order for onChange so event is first.
4 participants
@Dominik-Petrik @patternfly-build @nicolethoen @tlabaj