chore(OptionsMenu): deprecate #8798
Conversation
|
Preview: https://patternfly-react-pr-8798.surge.sh A11y report: https://patternfly-react-pr-8798-a11y.surge.sh |
There was a problem hiding this comment.
This looks fine to me. But @tlabaj @nicolethoen @evwilkin do we really want to rename the tab "React deprecated." I think we are planning to add a banner and a label to these component pages, correct? I know that is something still being worked out. So also adding "deprecated" to the tab might feel redundant, but welcome you thoughts.
|
@mcarrano I personally don't think hurts to be redundant, but I see what you mean. |
|
@mcarrano I agree with @nicolethoen Nicole. I do not think it hurts to call the tab "React deprecated " It will be consistent with other deprecated react components that have a new implementation. |
|
@nicolethoen @tlabaj thanks for your feedback. I went ahead and approved then. |
| onToggle={(event: any, value: boolean) => { | ||
| props.onToggle(value); | ||
| onToggle={(event: any) => { | ||
| props.onToggle(event); |
There was a problem hiding this comment.
looks like this was missed with the onToggle changes
gitdallas
force-pushed
the
chore/deprecate-options-menu
branch
from
0601e30
to
04ae231
Compare
There was a problem hiding this comment.
Continuing from standup today, don't think there would be any significant difference between getting this in first vs #8072 so I'd be good with making any necessary updates in these files if this gets merged first.
What: Closes #8075
https://patternfly-react-pr-8798.surge.sh/components/options-menu
OptionsMenu uses in demos and examples have been commented out until Select next is promoted. We can replace OptionsMenu with the new Select after that goes in. #8073