feat(Page): Deprecate PageHeader component #8854
Conversation
|
Preview: https://patternfly-react-pr-8854.surge.sh A11y report: https://patternfly-react-pr-8854-a11y.surge.sh |
There was a problem hiding this comment.
In addition the the file comments below:
- In the Page.md file, the
Uncontrolled navigation" example still mentions<PageHeader` in the example description. - The "Flyout nav" demo in the Nav.md file has PageHeader and PageHeaderTools imported from react-core still
packages/react-core/src/components/Page/examples/PageVerticalNavUsingPageHeaderComponent.tsx
Show resolved
Hide resolved
| @@ -119,3 +112,10 @@ The content in this example is placed in a card to better illustrate how the sec | |||
|
|
|||
| ```ts file="./PageCenteredSection.tsx" | |||
| ``` | |||
|
|
|||
| ### Deprecated page header | |||
There was a problem hiding this comment.
Can we move this example into it's own file in the deprecated folder along with the PageHeader. That way it would show up under a deprecated tab. That way the non recommend solution is not shown on the main Page page.
cc @mcarrano what do you think?
There was a problem hiding this comment.
@tlabaj I think so, but let me make sure I understand. Are you saying that when the user goes to the Page component, they will then see two React tabs? One with the masthead examples and another called "React deprecated" that has the old example using the PageHeader? I guess that's OK.
There was a problem hiding this comment.
Yes. That is what I am saying. This one example using the PageHeader would be in the React deprecated tab.
nicolethoen
force-pushed
the
deprecate_page_header
branch
from
6f605f2
to
7f7ddea
Compare
| propComponents: ['PageHeader','PageHeaderTools','PageHeaderToolsGroup','PageHeaderToolsItem'] | ||
| --- | ||
|
|
||
| ## PageHeader |
There was a problem hiding this comment.
can we change to "Page header"
nicolethoen
force-pushed
the
deprecate_page_header
branch
from
7f7ddea
to
6a70b52
Compare
| propComponents: ['PageHeader','PageHeaderTools','PageHeaderToolsGroup','PageHeaderToolsItem'] | ||
| --- | ||
|
|
||
| ## PageHeader examples |
There was a problem hiding this comment.
Can we update this to "Page header examples"
|
@nicole can you address Austin's comment when you resolve conflicts? |
nicolethoen
force-pushed
the
deprecate_page_header
branch
from
79678f3
to
924ee27
Compare
What: Closes #8602