feat(styled-system): adds styled system to pf4 as its own package #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-React preview: https://891-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 3141
💛 - Coveralls |
|
@dmiller9911 I think I have addressed most of your comments in #836 here. I am exporting out a PatternFlyThemeProvider that a user needs to place within their component tree, which can be overridden. Additionally most of the theme uses global vars (instead of values) so it also respects global overrides. |
jschuler
requested review from
dmiller9911,
priley86,
dlabaj,
tlabaj and
karelhala
dgutride
approved these changes
Nov 12, 2018
tlabaj
approved these changes
Nov 12, 2018
dlabaj
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adds the @patternfly/react-styled-system package with the styled-system components
First commit: Generated package structure
Second commit: The styled-system component and additional misc package changes if needed