feat(PageSidebar): added SidebarBody component #8942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-8942.surge.sh A11y report: https://patternfly-react-pr-8942-a11y.surge.sh |
thatblindgeye
force-pushed
the
iss8386_pageSidebarContent
branch
from
524c19f
to
b101a6c
Compare
tlabaj
approved these changes
Apr 17, 2023
nicolethoen
approved these changes
Apr 20, 2023
thatblindgeye
force-pushed
the
iss8386_pageSidebarContent
branch
from
b101a6c
to
38d776b
Compare
gitdallas
approved these changes
Apr 24, 2023
kmcfaul
approved these changes
Apr 25, 2023
thatblindgeye
force-pushed
the
iss8386_pageSidebarContent
branch
from
38d776b
to
9df83ea
Compare
mcoker
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
LGTM. I noticed there are some docs around isFilled on <PageSection>s mentioning that the last page section is filled by default, which is a (the?) use case for isFilled={false}. <PageSidebarBody> behaves the same way - not sure if it's worth mentioning?
thatblindgeye
force-pushed
the
iss8386_pageSidebarContent
branch
from
9df83ea
to
dc4539c
Compare
|
@mcoker good callout, added some short verbiage regarding that to the "Multiple sidebar body" example |
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8386
This may require the
sideNavLayoutin org to be updated again since that is also using PageSidebar (right now the sidebar in the app won't have any content rendered despite being able to open/close it).Links to where updates should apply (will need to manually update the URL in the address bar to get to any other page):
Page component
Nav component
Notification drawer component
Wizard component
Masthead demos
Additional issues: