fix(DataList, Table): update hoverable reference to clickable #9083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-9083.surge.sh A11y report: https://patternfly-react-pr-9083-a11y.surge.sh |
kmcfaul
approved these changes
May 8, 2023
thatblindgeye
approved these changes
May 9, 2023
There was a problem hiding this comment.
This looks good. One thing I noticed, which could be a followup since it's something that needs updating in other places, is in the DataListClickableRows example and the Tr component code, the usage of pf-screen-reader just needs to be updated to pf-v5-screen-reader (this one slipped by during the collision work)
|
I'll fix it |
tlabaj
reviewed
May 10, 2023
|
thatblindgeye
approved these changes
May 11, 2023
tlabaj
approved these changes
May 11, 2023
KKoukiou
added a commit
to KKoukiou/cockpit
that referenced
this pull request
May 23, 2023
KKoukiou
added a commit
to KKoukiou/cockpit
that referenced
this pull request
Jun 7, 2023
jelly
pushed a commit
to KKoukiou/cockpit
that referenced
this pull request
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9001
This is clean up after core work: patternfly/patternfly#5397
basically, hoverable classnames for DataList and Table have been changed to clickable.
Changes here:
isHoverableprop toisClickable