Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(subcomponents): Make all subcomponents available from base component #916

Merged
merged 1 commit into from
Nov 15, 2018
Merged

fix(subcomponents): Make all subcomponents available from base component #916

merged 1 commit into from
Nov 15, 2018

Conversation

jeff-phillips-18
Copy link
Member

This allows all subcomponents to be available from the pf-react packages.

@mareklibra

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://916-pr-patternfly-react-patternfly.surge.sh

@coveralls
Copy link

coveralls commented Nov 13, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 3228

  • 53 of 53 (100.0%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 81.337%
Totals Coverage Status
Change from base Build 3219: 0.2%
Covered Lines: 3839
Relevant Lines: 4448
💛 - Coveralls

@jeff-phillips-18
Copy link
Member Author

See #894 (comment) for context.

cdcabrera
cdcabrera reviewed Nov 14, 2018
View reviewed changes
Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round quick review, couple of notes/questions and a possible issue

packages/patternfly-3/patternfly-react/src/components/Cards/Card.js Outdated Show resolved Hide resolved
packages/patternfly-3/patternfly-react/src/components/Cards/Card.js Outdated Show resolved Hide resolved
packages/patternfly-3/patternfly-react/src/components/Label/Label.js Show resolved Hide resolved
cdcabrera
cdcabrera reviewed Nov 14, 2018
View reviewed changes
Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 2... optional update, comment/question

...ges/patternfly-3/patternfly-react/src/components/ToastNotification/TimedToastNotification.js Show resolved Hide resolved
packages/patternfly-3/patternfly-react/src/components/TypeAheadSelect/TypeAheadSelect.js Show resolved Hide resolved
@jeff-phillips-18
fix(subcomponents): Make all subcomponents avaliable from base component
f557693 
This allows all subcomponents to be available from the pf-react packages.
@mareklibra mareklibra mentioned this pull request Nov 15, 2018
Merged
@dtaylor113 dtaylor113 merged commit 4c4989b into patternfly:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdcabrera cdcabrera cdcabrera approved these changes

@dtaylor113 dtaylor113 dtaylor113 approved these changes

@mareklibra mareklibra mareklibra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jeff-phillips-18 @patternfly-build @coveralls @cdcabrera @dtaylor113 @mareklibra