Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-icons): Added fallback width and height attributes to icons #9257

Merged
merged 3 commits into from Jun 12, 2023
Merged

fix(react-icons): Added fallback width and height attributes to icons #9257

merged 3 commits into from Jun 12, 2023

Conversation

wise-king-sullyman
Copy link
Contributor

Closes #9256

@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 9, 2023 •
edited

Preview: https://patternfly-react-pr-9257.surge.sh

A11y report: https://patternfly-react-pr-9257-a11y.surge.sh

mcoker
mcoker approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tlabaj
tlabaj approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 5c782ba into patternfly:main Jun 12, 2023
10 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.0.0-prerelease.7
  • @patternfly/react-core@5.0.0-prerelease.7
  • @patternfly/react-docs@6.0.0-prerelease.7
  • @patternfly/react-icons@5.0.0-prerelease.3
  • demo-app-ts@5.0.0-prerelease.5
  • @patternfly/react-table@5.0.0-prerelease.7

Thanks for your contribution! 🎉

@wise-king-sullyman wise-king-sullyman deleted the fix-svg-sizes branch June 12, 2023 17:59
nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
@wise-king-sullyman @nicolethoen
fix(react-icons): Added fallback width and height attributes to icons (…
62b2a63 
…patternfly#9257)

* fix(react-icons): Added fallback width and height attributes to icons

* chore(tests): updated snapshots

* chore(tests): updated more snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcoker mcoker mcoker approved these changes

@tlabaj tlabaj tlabaj approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@nicolethoen nicolethoen Awaiting requested review from nicolethoen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - react icons - icons nested inside other SVGs are incorrectly sized
6 participants
@wise-king-sullyman @patternfly-build @mcoker @tlabaj @kmcfaul @thatblindgeye