Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SelectDeprecated): use textinput component for typeahead #9317

Merged
merged 3 commits into from Jul 6, 2023
Merged

fix(SelectDeprecated): use textinput component for typeahead #9317

merged 3 commits into from Jul 6, 2023

Conversation

gitdallas
Copy link
Contributor

@gitdallas gitdallas commented Jun 28, 2023 •
edited by tlabaj

Closes #9324

@gitdallas gitdallas requested review from mcoker and tlabaj June 28, 2023 21:29
@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 28, 2023 •
edited

Preview: https://patternfly-react-pr-9317.surge.sh

A11y report: https://patternfly-react-pr-9317-a11y.surge.sh

@gitdallas
Copy link
Contributor Author

gitdallas commented Jun 29, 2023 •
edited

The timestamp appeared to be off by 1 second.. reran the tests and they passed.

tlabaj
tlabaj approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcoker
mcoker approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥸👍

kmcfaul
kmcfaul approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 4199e4a into patternfly:main Jul 6, 2023
10 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.0.0-prerelease.17
  • @patternfly/react-core@5.0.0-prerelease.17
  • @patternfly/react-docs@6.0.0-prerelease.17
  • demo-app-ts@5.0.0-prerelease.15
  • @patternfly/react-table@5.0.0-prerelease.17

Thanks for your contribution! 🎉

nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
@gitdallas @nicolethoen
fix(SelectDeprecated): use textinput component for typeahead (pattern…
f8adb72 
…fly#9317)

* fix(SelectDeprecated): use textinput component for typeahead

* remove commented out code

* remove duplicate form control class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcoker mcoker mcoker approved these changes

@tlabaj tlabaj tlabaj approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

Assignees
No one assigned
Labels
css review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - [select] - [html structure for typeahead should match core]
5 participants
@gitdallas @patternfly-build @mcoker @tlabaj @kmcfaul