feat(Toolbar): update/add alignItems + alignSelf #9325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-9325.surge.sh A11y report: https://patternfly-react-pr-9325-a11y.surge.sh |
tlabaj
approved these changes
Jul 6, 2023
|
Should examples be added? |
mattnolting
approved these changes
Jul 6, 2023
nicolethoen
approved these changes
Jul 6, 2023
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9194
Allows
alignItemsandalignSelfonToolbarContent,ToolbarGroupandToolbarItemto have valuesstart,center, andbaseline.Some of the props were already present so updated the allowed values where they already existed. The existing props also allow a
defaultvalue that doesn't apply any css, which I kept in the added props for consistency.