Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(brand): allowed heights/widths to be set together and be used when no children are passed #9342

Merged
merged 2 commits into from Jul 11, 2023

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented Jul 10, 2023

fixes #9341

@mcoker mcoker requested a review from tlabaj July 10, 2023 21:14
@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 10, 2023

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tlabaj tlabaj merged commit eca7300 into patternfly:main Jul 11, 2023
10 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.0.0-prerelease.20
  • @patternfly/react-core@5.0.0-prerelease.20
  • @patternfly/react-docs@6.0.0-prerelease.22
  • demo-app-ts@5.0.0-prerelease.18
  • @patternfly/react-table@5.0.0-prerelease.20

Thanks for your contribution! 🎉

nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
…n no children are passed (patternfly#9342)

* fix(brand): allowed heights/widths to be set together and be used when no children are passed

* chore(brand): docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Brand - setting heights and widths together results in only heights being set
5 participants