chore(Wizard) convert demos to TS #9479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-9479.surge.sh A11y report: https://patternfly-react-pr-9479-a11y.surge.sh |
|
Looks like this is failing a few of the CI checks |
Dominik-Petrik
force-pushed
the
wizard-convertDemoToTS
branch
from
cab703a
to
fc656f0
Compare
|
Looks like this is blocked by #9553, is that correct? |
I don't think that's the blocker, just CI tests are not passing |
jenny-s51
force-pushed
the
wizard-convertDemoToTS
branch
2 times, most recently
from
3e5ec31
to
df94ba8
Compare
jenny-s51
force-pushed
the
wizard-convertDemoToTS
branch
from
df94ba8
to
ed884f3
Compare
revert to js to fix ci build fix dashboard wrapper paths declare demos as ts files fix imports add DashboardWrapper import to md file change back to js declarations to fix build remove dashboardwrapper import from md file
jenny-s51
force-pushed
the
wizard-convertDemoToTS
branch
from
f6b4430
to
eeb3714
Compare
wise-king-sullyman
approved these changes
Oct 16, 2023
wise-king-sullyman
requested changes
Oct 16, 2023
jenny-s51
reviewed
Oct 16, 2023
There was a problem hiding this comment.
Thank you for your review/feedback @wise-king-sullyman ! Good catch, I noticed that as well, along with some additional spacing/styling issues that should now be fixed with the latest commit 🙂
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9449