fix(LoginPage): Add submit error callback handling #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ron-Lavi
force-pushed
the
fix/login-page-submit-error-callback
branch
from
35b89ce
to
6ec52c4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Pull Request Test Coverage Report for Build 3334
💛 - Coveralls |
|
Deploy preview for patternfly-react-gone ready! Built with commit 6ec52c4 https://deploy-preview-952--patternfly-react-gone.netlify.com |
jeff-phillips-18
approved these changes
Nov 26, 2018
|
Thanks @jeff-phillips-18, I am about to work on it right now |
dtaylor113
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the LoginPage implementation in Foreman
Adding submit error callback to display the form error.
Added tests and storybook update.