Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Card): convert Card react demos to TS #9561

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

jenny-s51
Copy link
Contributor

What: Closes #9374

Converted remaining Card react demos to TS and fixed various linting / type errors

@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 31, 2023

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments/pretty quick updates below. Could we also create separate files for these demos in a demos/examples/CardDemos directory?

packages/react-core/src/demos/CardDemos.md Outdated Show resolved Hide resolved
packages/react-core/src/demos/CardDemos.md Outdated Show resolved Hide resolved
packages/react-core/src/demos/CardDemos.md Outdated Show resolved Hide resolved
packages/react-core/src/demos/CardDemos.md Outdated Show resolved Hide resolved
packages/react-core/src/demos/CardDemos.md Outdated Show resolved Hide resolved
packages/react-core/src/demos/CardDemos.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs a rebase.

WIP card demo conversion

chore(card): convert all demos to ts

Apply function name suggestions from Eric

Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>

split up demos, PR feedback from Eric

revert card view location and update name

fix card view data paths

fix tokens imports

fix tokens import paths

update import style to fix build

fix import path

add styling updates from main
@tlabaj tlabaj merged commit bf81164 into patternfly:main Oct 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert card react demos to TS
4 participants