fix(popper): improve flip behavior in RTL #9640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-9640.surge.sh A11y report: https://patternfly-react-pr-9640-a11y.surge.sh |
There was a problem hiding this comment.
FWIW, here's some screenshots showing how this update looks to improve things even in LTR. Both are using the Notification Drawer example with some padding removed.
From the React staging site (with default position of "left" for the dropdown menu):
From this PR preview, also using position of "left" on the dropdown:
The dropdown menu gets repositioned a bit to keep it from overflowing off screen with this PR.
kmcfaul
approved these changes
Sep 21, 2023
jenny-s51
approved these changes
Sep 21, 2023
|
@thatblindgeye yeah I can add it to the various |
thatblindgeye
approved these changes
Oct 25, 2023
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
wise-king-sullyman
force-pushed
the
popper-fix-rtl-flipping
branch
from
61e779d
to
9dd2db3
Compare
kmcfaul
approved these changes
Oct 27, 2023
|
LGTM |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9639
Additional issues: