Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs #30

Closed
4 of 6 tasks
LHinson opened this issue Mar 8, 2018 · 4 comments
Closed
4 of 6 tasks

Tabs #30

LHinson opened this issue Mar 8, 2018 · 4 comments
Assignees
@andybraren
Projects
PatternFly-Next Feature Board
Milestone
1.0.0-alpha.8

Comments

@LHinson
Copy link
Member

LHinson commented Mar 8, 2018 •
edited by andybraren

Introduce tabs

Tabs Design - Examples + spacing spec
PF4_Tabs.pdf

  • Interaction design requirements
  • Visuals
  • First checkpoint complete and approved
  • CSS
  • React
  • Second checkpoint complete and approved

Contacts:

  • IxD
  • Visual
  • CSS - Andy
@LHinson LHinson added the Feature end user feature that requires design to define this, i.e. changes or augments the user experience. label Mar 8, 2018
@mcarrano mcarrano added this to New Feature Request in PatternFly-Next Feature Board Apr 6, 2018
@mcarrano
Copy link
Member

There is an existing issue in patternfly-design that should be considered here: patternfly/patternfly-design#526

@mcarrano
Copy link
Member

Consider need for better guidance on tab usage as we document this component. See patternfly/patternfly-design#526

@LHinson LHinson added this to the 1.0.0-beta.1 milestone Jun 1, 2018
@LHinson LHinson moved this from Backlog to Visual Design in PatternFly 4 Feature Board Jun 1, 2018
@LHinson LHinson added alpha 4 and removed beta 1 labels Jun 20, 2018
@dgutride dgutride added alpha 4 and removed alpha 4 labels Jul 24, 2018
@LHinson LHinson removed the alpha 4 label Aug 1, 2018
@LHinson LHinson modified the milestones: 1.0.0-alpha.4, 1.0.0-alpha.5 Aug 1, 2018
@LHinson LHinson moved this from Visual Design to Discovery (IxD Requirements) in PatternFly 4 Feature Board Aug 2, 2018
@LHinson LHinson modified the milestones: 1.0.0-alpha.5, 1.0.0-alpha.6 Aug 3, 2018
@LHinson LHinson removed the alpha 4 label Aug 13, 2018
@LHinson LHinson modified the milestones: 1.0.0-alpha.5, 1.0.0-alpha.7 Aug 17, 2018
@LHinson LHinson moved this from Discovery (IxD Requirements) to Visual Design in PatternFly 4 Feature Board Aug 21, 2018
@mcarrano
Copy link
Member

Design Leads review Aug 30:

  • Consider whether left/right buttons move +/- one tab or scroll you to first/last.
  • Consider when to use flex vs. fixed layout for tabs

@mceledonia
Copy link

mceledonia commented Sep 5, 2018 •
edited

Tabs Design - Examples + spacing spec
PF4_Tabs.pdf

Updated Sep 6, 2018

@mcarrano mcarrano moved this from Visual Design to Checkpoint 1 in PatternFly 4 Feature Board Sep 7, 2018
@LHinson LHinson added the P2 label Sep 10, 2018
@LHinson LHinson modified the milestones: 1.0.0-alpha.7, 1.0.0-alpha.6 Sep 11, 2018
@LHinson LHinson added css and removed visuals labels Sep 11, 2018
@LHinson LHinson moved this from Checkpoint 1 to CSS/HTML Development in PatternFly 4 Feature Board Sep 11, 2018
@LHinson LHinson modified the milestones: 1.0.0-alpha.6, 1.0.0-alpha.7 Oct 18, 2018
@andybraren andybraren mentioned this issue Oct 29, 2018
Merged
@LHinson LHinson modified the milestones: 1.0.0-alpha.7, 1.0.0-beta.1 Nov 9, 2018
@mcarrano mcarrano removed this from CSS/HTML Development in PatternFly 4 Feature Board Jan 15, 2019
@mcarrano mcarrano mentioned this issue Aug 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andybraren andybraren

Labels
None yet
Projects
No open projects
PatternFly-Next Feature Board
New Feature Request
Milestone
1.0.0-alpha.8
Development

No branches or pull requests
5 participants
@mcarrano @dgutride @LHinson @andybraren @mceledonia