fix(chip-group): fixed chip label overflow ellipsis #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcoker
requested review from
matthewcarleton,
mattnolting and
christiemolloy
|
PatternFly-Next preview: https://patternfly-next-pr-2552.surge.sh |
matthewcarleton
approved these changes
Dec 20, 2019
christiemolloy
approved these changes
Dec 23, 2019
|
🎉 This PR is included in version 2.46.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2524
@matthewcarleton tagging you since you made this change in #1287. Here's the commit - 967855b
As far as I can tell, that isn't needed as we don't apply any flex properties to children in it. If it was to make it an inline element regardless the element used for the label, we could use
inline-blockinstead.