Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(login): centered login on larger viewports #2754

Merged
merged 2 commits into from
Feb 27, 2020
Merged

fix(login): centered login on larger viewports #2754

merged 2 commits into from
Feb 27, 2020

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented Feb 27, 2020

fixes #2729

@patternfly-build
Copy link

patternfly-build commented Feb 27, 2020 •
edited
Loading

Preview: https://patternfly-next-pr-2754.surge.sh

CSS Size Report
NameCurrentPreviousDiff %
components/Drawer/drawer.css18.8 kB7.7 kB58.88
patternfly-no-reset.css666.5 kB655.9 kB1.59
patternfly.css668.3 kB657.7 kB1.59
patternfly.min.css587.0 kB577.8 kB1.56
components/DataToolbar/data-toolbar.css25.2 kB24.8 kB1.45
patternfly-ie11.css520.8 kB513.9 kB1.33
components/Page/page.css22.1 kB22.5 kB-1.70
components/Login/login.css13.2 kB13.7 kB-3.32

A11y report: https://patternfly-next-pr-2754-coverage.surge.sh

mceledonia
mceledonia approved these changes Feb 27, 2020
View reviewed changes
Copy link

@mceledonia mceledonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I absolutely smashed that approve button

mattnolting
mattnolting approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@mattnolting mattnolting merged commit 04f79fd into patternfly:master Feb 27, 2020
@redallen
Copy link
Contributor

🎉 This PR is included in version 2.66.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker mentioned this pull request Mar 3, 2020
Closed
rhamilto
rhamilto reviewed Apr 1, 2020
View reviewed changes
src/patternfly/components/Login/login.scss
@@ -117,7 +116,6 @@
}

.pf-c-login__container {
width: 100%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change resulted in a regression where the container can be smaller than the viewport at mobile.

oauth-openshift apps rhamilto devcluster openshift com_oauth_authorize_client_id=console redirect_uri=https%3A%2F%2Fconsole-openshift-console apps rhamilto devcluster openshift com%2Fauth%2Fcallback response_type=code scope=user%3Afull (1)

www patternfly org_v4_documentation_react_components_loginpage_basic(iPhone 6_7_8)

I'm pretty sure we're going to want this back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that Robb, I'll try and look at #2913 later today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put up a PR and added a comment to the code so hopefully that shouldn't be removed again. #2917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto left review comments

@mattnolting mattnolting mattnolting approved these changes

@mceledonia mceledonia mceledonia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mcoker @patternfly-build @redallen @rhamilto @mattnolting @mceledonia