fix(chipgroup): update removable action icon #3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiemolloy
requested review from
mattnolting,
maryshak1996,
mceledonia and
mcoker
|
Preview: https://patternfly-pr-3249.surge.sh A11y report: https://patternfly-pr-3249-coverage.surge.sh
|
|
@christiemolloy I think that the spacing that you have works well (I thought that what was in the design kit was quite tight anyway) -- @mceledonia what do you think? |
mattnolting
approved these changes
Jul 8, 2020
mcoker
approved these changes
Jul 8, 2020
|
@christiemolloy for some reason, I am still unable to get the surge preview working -- I am just getting this failure walrus... |
mcoker
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3247
@maryshak1996 @mceledonia I noticed the removable action doesn't have the same spacing as in the design kit. Do you know the actual px for the padding ?