fix(form-control): added vars for textarea width/height for resizing #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-pr-3883.surge.sh
A11y report: https://patternfly-pr-3883-coverage.surge.sh |
mattnolting
reviewed
Feb 25, 2021
|
@mattnolting when we initially introduced the resize modifiers in #2251 (comment), we decided not to impose any limitations on the ability to resize the width/height with the default textarea. It could also be considered a breaking change to do that at this point. |
|
@mcoker yes, this should be sufficient to autosize the textarea based on the scrollWidth/scrollHeight . |
|
🎉 This PR is included in version 4.89.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3837
Allows textarea to be resized via
--pf-c-form-control--textarea--Widthand--pf-c-form-control--textarea--Height@tlabaj can you let me know if this is enough to support autosize/resize?