Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): added critical-risk pficon #4758

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented Mar 25, 2022

fixes #4747

@patternfly-build
Copy link

patternfly-build commented Mar 25, 2022

Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcoker other than seeing that you did add this to the files attached in this PR, is there anything else I can or should do to review this. So far, looks good as far as I can tell.

@mcoker
Copy link
Contributor Author

mcoker commented Mar 25, 2022

@mcarrano just verify it looks OK on the icon page - https://patternfly-pr-4758.surge.sh/icons

@mcarrano
Copy link
Member

@mcoker OK. Forgot about that page. Yes, I see it and it looks good. But I do have another question- In your comment here: #4747 (comment), you noted that the other three icons were already present in the icon set. If that's the case, how come they don't show up on the Icons page referenced above?

@mcoker
Copy link
Contributor Author

mcoker commented Mar 28, 2022

@mcarrano the icons on that page are from the "pficon" icon font - the other icons are part of Font Awesome solid. I could probably update that page to include our bundled FAS icons, too, if you think that would be helpful.

@mcoker mcoker requested a review from mcarrano March 28, 2022 15:32
@mcarrano
Copy link
Member

@mcoker that's probably not necessary since it's not a page that appears publicly on the website. I will approve.

Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mcoker !

@mcoker mcoker merged commit a2c12b1 into patternfly:main Mar 28, 2022
@patternfly-build
Copy link

🎉 This PR is included in version 4.185.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@doruskova
Copy link

@mcoker Thank you a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom critical icon to a PF icons set
4 participants