Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4872 fix(tabledemo): fixes removal of bullseye layouts #4904

Merged
merged 2 commits into from Jun 15, 2022

Conversation

blfetche
Copy link
Contributor

Removed reference to bullseye handle bar code

@blfetche blfetche requested review from mcoker and srambach June 14, 2022 20:42
@patternfly-build
Copy link

patternfly-build commented Jun 14, 2022

@blfetche blfetche changed the title fix(tabledemo): fixes removal of bullseye layouts Fixes #4872 fix(tabledemo): fixes removal of bullseye layouts Jun 14, 2022
@blfetche blfetche linked an issue Jun 14, 2022 that may be closed by this pull request
Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny thing, otherwise great! Welcome to handlebars 🤣

{{#> empty-state empty-state--modifier="pf-m-sm"}}
{{#> empty-state-icon empty-state-icon--type="search"}}{{/empty-state-icon}}
{{#> title titleType="h2" title--modifier="pf-m-lg"}}
No results found
No results found Testing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to remove this 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected and thank you.

Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect! 🎉

@mattnolting mattnolting self-requested a review June 15, 2022 14:02
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@mattnolting mattnolting merged commit 870f1d3 into patternfly:main Jun 15, 2022
@patternfly-build
Copy link

🎉 This PR is included in version 4.196.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blfetche
Copy link
Contributor Author

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table demo cleanup
4 participants