New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4872 fix(tabledemo): fixes removal of bullseye layouts #4904
Conversation
Preview: https://patternfly-pr-4904.surge.sh A11y report: https://patternfly-pr-4904-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny thing, otherwise great! Welcome to handlebars 🤣
{{#> empty-state empty-state--modifier="pf-m-sm"}} | ||
{{#> empty-state-icon empty-state-icon--type="search"}}{{/empty-state-icon}} | ||
{{#> title titleType="h2" title--modifier="pf-m-lg"}} | ||
No results found | ||
No results found Testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to remove this 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected and thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
🎉 This PR is included in version 4.196.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks all! |
Removed reference to bullseye handle bar code