Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4872 fix(tabledemo): fixes removal of bullseye layouts #4904

Merged
merged 2 commits into from Jun 15, 2022
Merged

Fixes #4872 fix(tabledemo): fixes removal of bullseye layouts #4904

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12469ed
fix(tabledemo): fixes removal of bullseye layouts
blfetche Jun 14, 2022
ca81f98
fix(tabledemo): fixes typo in content
blfetche Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/patternfly/demos/Table/table-empty-state-table.hbs
View file
Open in desktop
Expand Up @@ -27,11 +27,10 @@
{{#> table-tbody}}
{{#> table-tr}}
{{#> table-td table-td--attribute='colspan="8"'}}
{{#> bullseye}}
{{#> empty-state empty-state--modifier="pf-m-sm"}}
{{#> empty-state-icon empty-state-icon--type="search"}}{{/empty-state-icon}}
{{#> title titleType="h2" title--modifier="pf-m-lg"}}
No results found
No results found Testing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to remove this 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected and thank you.

{{/title}}
{{#> empty-state-body}}
No results match the filter criteria. Remove all filters or clear all filters to show results.
Expand All @@ -42,7 +41,6 @@
{{/button}}
{{/empty-state-primary}}
{{/empty-state}}
{{/bullseye}}
{{/table-td}}
{{/table-tr}}
{{/table-tbody}}
Expand Down
2 changes: 0 additions & 2 deletions src/patternfly/demos/Table/table-loading-table.hbs
View file
Open in desktop
Expand Up @@ -27,7 +27,6 @@
{{#> table-tbody}}
{{#> table-tr}}
{{#> table-td table-td--attribute='colspan="8"'}}
{{#> bullseye}}
{{#> empty-state empty-state--modifier="pf-m-sm"}}
{{#> empty-state-icon}}
{{#> spinner}}Loading...{{/spinner}}
Expand All @@ -36,7 +35,6 @@
Loading
{{/title}}
{{/empty-state}}
{{/bullseye}}
{{/table-td}}
{{/table-tr}}
{{/table-tbody}}
Expand Down